Hello Bálint, On Tue, 2011-02-22 at 10:45 +0100, Bálint Dózsa wrote:
> I fixed this bug: > https://bugs.freedesktop.org/show_bug.cgi?id=32574 > My code is under the LGPLv3+/MPL dual license. First, thanks for your patches. I appreciate you taking some time to look into this matter. However, we have two different fixes to this, one by you that modifies the keyboard shortcut, and one by Takeshi (attached to the bugzilla page) that modifies the key input handler code directly. It's my opinion that Takeshi's approach is the right one. Shift Backspace still needs to clear selection when used while range selection is active, and your change modifies it, which is not desirable. Plus you assigned the key shortcut to Writer's shortcut for some reason. Takeshi's approach OTOH is limited to the case of direct cell-internal editing, and modifies the right part of the code which handles direct key input. So, I'll take Takeshi's patch for this, but please keep tackling those easy hacks. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc <kyosh...@novell.com> _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
