So my GNOME settings are by default to not show icons in menus so I
didn't notice that we show a placeholder graphic for all missing icons
in menus.
That means though that *all* menu entries have an icon beside them when
icons are turned on, and a load of them are the broken graphic
placeholder.
Where are we on the thinking/plan here...
Do we think that every entry *should* have an icon and that each missing
one is a bug and needs to be drawn.
Or do we think that it's ok to have no menu entry icon and should just
draw no placeholder, e.g. something like the attached patch ? when they
are missing.
C.
diff --git a/framework/source/uiconfiguration/imagemanagerimpl.cxx b/framework/source/uiconfiguration/imagemanagerimpl.cxx
index bca1f2d..bdd0347 100644
--- a/framework/source/uiconfiguration/imagemanagerimpl.cxx
+++ b/framework/source/uiconfiguration/imagemanagerimpl.cxx
@@ -363,15 +363,7 @@ GlobalImageList::~GlobalImageList()
Image GlobalImageList::getImageFromCommandURL( sal_Int16 nImageType, const rtl::OUString& rCommandURL )
{
osl::MutexGuard guard( getGlobalImageListMutex() );
- Image aImage = CmdImageList::getImageFromCommandURL( nImageType, rCommandURL );
- if (!aImage)
- {
- BitmapEx rBitmap;
- bool res = ::vcl::ImageRepository::loadDefaultImage(rBitmap);
- if (res)
- aImage = Image(rBitmap);
- }
- return aImage;
+ return CmdImageList::getImageFromCommandURL( nImageType, rCommandURL );
}
bool GlobalImageList::hasImage( sal_Int16 nImageType, const rtl::OUString& rCommandURL )
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
