Hi Khaled, On 2011-01-11 at 18:57 +0200, Khaled Hosny wrote:
> > It should be tested with some CTL scripts including reordering and > > lots of diacritics to check the edge cases are covered. The width > > will also affect font fallback (calls from MultiSalLayout), so that > > needs to be tested as well. > > I've tested with fonts that make extensive use of combining marks and no > major problems so far, however width of fallback glyphs seems to be > miscalculated when followed by kerned glyphs but I'm yet to understand > what is going on with fallback. Testing with scripts that require glyph > reordering still needed, but I don't speak any. I am so sorry that the review of this takes so much time :-( - but I suppose most of the people have the same problem - not understanding enough scripts to be able to test reliably. I tried to push your patch so that it functions only in the Experimental mode (that you can switch it on in the Options... dialog); unfortunately the patch modifies too low-level stuff be able to make use of that value :-( Anybody here with ideas what we can do so that the patch helps Khaled, and is as safe as possible? - so that we can commit it, and fix the consequences later if anything happens? Thank you a lot, Kendy _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
