On Mon, Jan 24, 2011 at 2:42 PM, Albert Thuswaldner <albert.thuswald...@gmail.com> wrote: > On Thu, Jan 20, 2011 at 11:08, Michael Meeks <michael.me...@novell.com> wrote: >> Hi Albert, >> >> First - thanks for helping out with this ! as you can see we have big >> German comment problems, and it is simply great to have help improving >> the situation: much appreciated :-) >> >> On Wed, 2011-01-19 at 16:54 -0700, Tor Lillqvist wrote: >>> I don't think you need to be that careful here. I think I can say with >>> confidence that boilerplate comments like the these: >> >> :-) >> >>> /************************************************************************* >>> |* >>> |* RscTop::Size() >>> |* >>> |* Beschreibung >>> |* Ersterstellung MM 29.10.91 >>> |* Letzte Aenderung MM 29.10.91 >>> |* >>> *************************************************************************/ >>> >>> are universally loathed by all developers. >> > > Hi Norbert, Tor and Michael, > Thanks for your advice and for cheering me on. I've cleaned up my > patch and submitted as a bug report. Please see: > > https://bugs.freedesktop.org/show_bug.cgi?id=33424 > > As it turned out the freedesktop bugzilla has file size limit of > 1000Kb for patches, as my patch weighs in at 1001Kb, I had to divide > it up in two parts. ;)
you should have gziped it (or zip or bzip2...) that save you and the reviewer bandwith, bugzilla disk space, and the patch is not meant to be reviewed online within bugzilla (here we just used bugzilla as a landing zone) Norbert > /Albert > _______________________________________________ > LibreOffice mailing list > LibreOffice@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/libreoffice > _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
