On Sat, 2011-01-08 at 23:50 +0000, Andy Hearn wrote:
> The cursor, when on a post-it note, now can go out of view when Joe
> User scrolls, and is correctly brought back into 'focus' if the user
> types something.
>
> But however, this patch shouldn't be pushed at all - I suspect that
> the hack which I've just removed probably breaks something somewhere.
>
> Even though I've bashed away at the Comments/Post-It Notes, and Writer
> in general; there appear to be no ill effects. I've tried to
> understand the necessity for this hack in the first place to no
> avail.
Lets ask,
max, do you remember the code in the postits that the attached patch
affects, can you remember what the problem was that needed fixing ?
C.
>From 5d237e53a3574dcef1f30ecf747ec6f7333cf829 Mon Sep 17 00:00:00 2001
From: Andrew W Hearn
Date: Sat, 8 Jan 2011 23:26:13 +0000
Subject: [PATCH] Removed suspect hack. Cursor on post-it now scrolls out of view.
Previously, when the user scrolls when the cursor is within a
post-it note, the main view judders, refusing to let the cursor
go out of view. The removed lines appears to have been a hack
to retain focus of a post-it note containing the cursor.
---
sw/source/ui/docvw/PostItMgr.cxx | 10 ----------
1 files changed, 0 insertions(+), 10 deletions(-)
diff --git a/sw/source/ui/docvw/PostItMgr.cxx b/sw/source/ui/docvw/PostItMgr.cxx
index e06d558..2d599c6 100644
--- a/sw/source/ui/docvw/PostItMgr.cxx
+++ b/sw/source/ui/docvw/PostItMgr.cxx
@@ -719,16 +719,6 @@ void SwPostItMgr::LayoutPostIts()
OSL_ENSURE(mPages[n]->bScrollbar,"SwPostItMgr::LayoutByPage(): note overlaps, but bScrollbar is not true");
}
}
-
- // do some magic so we really see the focused note
- for(SwSidebarWin_iterator i = aVisiblePostItList.begin(); i!= aVisiblePostItList.end() ; i++)
- {
- if ((*i)->HasChildPathFocus())
- {
- MakeVisible((*i),n+1);
- break;
- }
- }
}
else
{
--
1.7.0.4
_______________________________________________
LibreOffice mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
