Hi Kohei, On 2010-12-23 at 12:41 -0500, Kohei Yoshida wrote:
> I just fixed the following bug: > https://bugs.freedesktop.org/show_bug.cgi?id=32570 > > and would like to port the fix to 3.3. Here is the relevant commit > http://cgit.freedesktop.org/libreoffice/calc/commit/?id=98764831e3b6c02d7630c61a6c389ce4318787bd > > Here is some risk analysis. > > The worst case this change would cause is that some formula strings that > should have been flagged bad may be accepted (e.g. 100.A1 where the 100 > is a sheet name). > > But I would say the risk of that happening is quite low since we already > automatically detect numerical sheet names and quote them, so chances > are that we won't run into an unquoted numerical sheet name followed by > a '.'. Plus, the current code breaks legitimate cases as evident in the > bug report. > > Also, we support multiple formula syntaxes and a '.' is not always the > sheet-to-reference separator, which makes this check totally wrong in > our code base. Sounds reasonable, looks good, pushed :-) Thank you, Kendy _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
