Hi there, Just fixed the following bug on master
https://bugs.freedesktop.org/show_bug.cgi?id=32523 The fix was rather simple, as this commit shows http://cgit.freedesktop.org/libreoffice/libs-gui/commit/?id=90c9dcfde572f227eae0760066af5b8a9d5d9218 However, not fixing this may cause some hard to detect bugs somewhere else especially when the language is not English. So, I feel *strongly* that we need to port this to 3.3. SvNumberFormatter has many methods that take a language as an argument, with the default value of LANGUAGE_DONTKNOW when the language is not specified. All such methods switch the language back to the initial language when the language is LANGUAGE_DONTKNOW, except for one method. And calling that method without specifying the language carries the default language value of DONTKNOW, which internally switches the language to English! We don't want this especially in non-English locales. This mostly affects csv imports, but a quick scanning of the code shows that there are several other places where this method is called without the language specified. So, this bug may be causing some weird number recognition bugs somewhere especially in non-English locales. I would appreciate someone reviewing the change and giving me a sign-off. Thanks, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc <kyosh...@novell.com> _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
