On Fri, 2010-11-12 at 15:32 +0000, Michael Meeks wrote: > On Fri, 2010-11-12 at 08:35 -0500, Kohei Yoshida wrote: > > Yes, I was aware of this, and even SvxHyperlinkDlgWrapper is never > > instantiated. It is registered by the applications on startup, but > > that's the only place I see it being used. > > Ah true ;-) I see there is a new cui/ hyperlink dialog that is used. > > > > Presuambly we came to that conclusion already as it is still there. > > > > Nope, it's there because I added it to the Easy Hack page. > > :-) I guess there is prolly other cruft that goes with it eg. the > several calls to: > > SFX_CHILDWINDOW_REGISTRATION( SID_HYPERLINK_INSERT ); > > and the: > > svx/source/dialog/hyprlink.cxx:SFX_IMPL_CHILDWINDOW(SvxHyperlinkDlgWrapper, > SID_HYPERLINK_INSERT) > > and of course mentions of that in various sdi and src files. > > Did you do the unwinding to satisfy yourself that whatever mapping > between SID_HYPERLINK_INSERT and this dialog is never exploited ?
Heh! The short story is that this dialog code still *is* used, as a Hyperlink *toolbar*. Go to View -> Toolbars -> Hyperlink Bar to enable a new toolbar to allow some sort of quick insertion of URL buttons. That toolbar makes use of SvxHyperlinkDlg. Ok I'm removing this task from the Easy Hack page. -- Kohei Yoshida, LibreOffice hacker, Calc <kyosh...@novell.com> _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
