https://bugs.documentfoundation.org/show_bug.cgi?id=100507

Miklos Vajna <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #11 from Miklos Vajna <[email protected]> ---
Bibisecting using bibisect-44max.git:

868fae4fac0679d728ca6ec756a4c3b5fda43a77 is the first bad commit
commit 868fae4fac0679d728ca6ec756a4c3b5fda43a77
Author: Matthew Francis <[email protected]>
Date:   Sat Mar 14 21:40:46 2015 +0800

    source-hash-1be0a3fa9ebb22b607c54b47739d4467acfed259

    commit 1be0a3fa9ebb22b607c54b47739d4467acfed259
    Author:     Michael Stahl <[email protected]>
    AuthorDate: Tue Jun 17 18:40:04 2014 +0200
    Commit:     Michael Stahl <[email protected]>
    CommitDate: Tue Jun 17 18:42:07 2014 +0200

        n#825305: writerfilter RTF import: override style properties like Word

        It would certainly be immediately obvious to any reader of the RTF spec
        that \sN will apply the style with index N to the current paragraph.

        But actually, that is not what Word does when it reads \sN...
        what it really does is to apply the style with index N, and then for
        every attribute in that style, apply the same attribute with a default
        value to the paragraph, effectively overriding what's in the style.

        If that doesn't make any sense to you, well, have you heard the joke
        about how many Microsoft engineers it takes to change a light bulb?

        Also, \pard apparently implies \s0.

        To implement that, change RTFSprms::deduplicate() to recursively
        look for style SPRMs that are missing in the properties, and put
        in default ones, currently just for 2 keywords \sa and \sb.

        This requires changing deduplicate() to be const and return a new
value,
        since it is no longer idempotent, as the erased SPRMs would get
        defaulted on the next run.

        While at it, fix RTFValue::equals() which did not compare m_sValue.

        This fixes the testParaBottomMargin test that was broken by the fix
        for fdo#70578.

        Change-Id: I4ced38628d76f6c41b488d608a804883493ff00b

:040000 040000 28e3aedf8721ecacc6cb7d7166ee96448d71d9ca
2824ba57aa0ff76d64e426af2ae5e20bc5e150a5 M      opt


Adding Cc: to [email protected]

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to