https://bugs.documentfoundation.org/show_bug.cgi?id=93563
Bug ID: 93563
Summary: volatile signal re-enterancy guards ...
Product: LibreOffice
Version: 5.0.0.0.beta1
Hardware: Other
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: medium
Component: graphics stack
Assignee: [email protected]
Reporter: [email protected]
cf.
http://www.gnu.org/software/libc/manual/html_node/Nonreentrancy.html#Nonreentrancy
When we have re-enterancy guards in our signal handlers - we should use the
'volatile' keyword eg.
oslSignalAction SAL_CALL VCLExceptionSignal_impl( void* /*pData*/,
oslSignalInfo* pInfo)
{
static bool bIn = false;
// if we crash again, bail out immediately
if ( !bIn )
should be static volatile bool bIn = false; =)
It would be good to chase through the code a little bit in this regard as there
are several signal handlers that (I suspect) do similar things - and
sub-methods that assume similar things.
Thanks !
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
