https://bugs.documentfoundation.org/show_bug.cgi?id=166571
Justin L <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.documentfounda | |tion.org/show_bug.cgi?id=16 | |0952 --- Comment #3 from Justin L <[email protected]> --- It looks like it probably was something ancient to resolve an old MS Word bug. The only native examples found were in the old .DOC format. I can't image that suppressing the space BEFORE the page break would have any real impact. It looks like we already have logic to completely collapse the space after a page break. It even has the distinction where it doesn't collapse after a section page break. SwFrame::IsCollapseUpper. Normally it never collapses for anything less than compat15 (see bug 160952). git log -p -L:SwFrame..IsCollapseUpper:sw/source/core/layout/calcmove.cxx IIUC the reason for that is because a page break (a w:br) is a character property that occurs in the middle of a paragraph. So that means that the paragraph has already started on the previous page - and therefore the above spacing would also be on the previous page. So then technically it is not collapsed - it just exists earlier. But for LO purposes it is collapsed (since a LO page break is only a paragraph property). But there is a way in DOCX to specify a normal page break as a paragraph property. I'll bet that this code breaks in that context. However in terms of this bug it shouldn't matter, because it says to always ignore the space after a normal page break - so it shouldn't matter how it is defined. So then it should be relatively easy to fix this, by adding a compat flag (like in bug 166503) that causes IsCollapseUpper and round-tripping it. But so far I can't see it really being worth fixing... -- You are receiving this mail because: You are the assignee for the bug.
