https://bugs.documentfoundation.org/show_bug.cgi?id=167358

Saburo <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Regression By|                            |Justin Luth
           Keywords|                            |bibisected, bisected
                 OS|Linux (All)                 |All
                 CC|                            |[email protected]

--- Comment #2 from Saburo <[email protected]> ---
bibisected with win64-25.8
commit  d4dad2e181fd2dc30c3916fd59c05745023a51c8
author  Justin Luth

tdf#156707 xmloff import: always provide ControlBorder property #2

In LO 7.5, ORichTextModel changed the app default to use a flat border
(in order to better match how PDF/print looks)
while the file-spec's default for undefined borders is 3d,
so during import time we ALWAYS need to specify 3d as the border.

The patch replaces 25.2 commit 5a617f77ee803eb65051e93f659ef66433879052
    tdf#156707 xmloff import: always provide ControlBorder property
which wasn't wrong, but just was incomplete.
It only handled the situation where there was a fo:border element
which didn't specify 3d/flat/none,
but didn't handle the situation where there was no fo:border at all
in style:graphic-properties.

[On export, since the 3d property is the default value,
fo:border is not even provided as something to be exported,
and therefore only "solid" and "none"
are ever exported as fo:border qualifiers.]

I modified the unit test to remove the fo:border
by clearing the unused-by-3d green border colour
(although the green was seen if the wrong flat border was assigned).

make CppunitTest_xmloff_style CPPUNIT_TEST_NAME=testTdf156707

Change-Id: I70718fe964a7c3578f8edbf8591fe2e3417ec60b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185619

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to