https://bugs.documentfoundation.org/show_bug.cgi?id=163436
Bug ID: 163436 Summary: Impress: deleted text in placeholder textbox fails to create an undo action Product: LibreOffice Version: Inherited From OOo Hardware: All OS: All Status: UNCONFIRMED Severity: minor Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jl...@mail.com CC: jl...@mail.com Blocks: 105948, 121741 When deleting placeholder text (for titles or text content for example), there is no ability to undo the deleted text. Steps to reproduce: 1.) open attachment 159314 (Paint.odp) 2.) Select all the title text "Header" and delete it. (Note that there is an textbox-undo entry "Delete") 3.) change focus by clicking on the slide itself above the title box. (Note that the title box changes to the default placeholder text "Click to add Title". Note the problem this bug report is complaining about - that there is no slide-undo entry for the changed textbox content.) The same thing is true for the text content placeholder. Already true in OOo 3.3. (There, an undo step is created, but it does nothing...) The do-nothing undo entry for the title stopped being created in 7.2 with commit f582670131dc211e472960ecff1826f7b133b083 Author: Mike Kaganski on Thu Jan 14 17:30:17 2021 +0100 Use value comparison here This was always comparing pointers, ever since commit cb07ed8c74d71de9ef512c7a3568c7ee85585cef. They could only happen to be not different if they are both nullptr. But the uses of the function seem to expect value comparison (see SdrObjEditView::ImpChainingEventHdl, SdrObjEditView::SdrEndTextEdit). Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109284 The do-nothing undo entry for the text content is too indeterminate to bibisect. Under certain steps (or perhaps timing) I can occasionally get an undo step being created. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=105948 [Bug 105948] [META] Undo/Redo bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=121741 [Bug 121741] Clicking in&out of text box with placeholder text sets presentation modified -- You are receiving this mail because: You are the assignee for the bug.