Yes, src/lib/ was an early attempt to implement the MHD2 API, while
src/microhttpd/ is what has always been used in production.
Note that we're now in the process of moving the MHD2 implementation
into a new libmicrohttpd2.git, and after that it would seem to
definitively be time to clean up (aka: remove) the src/lib/ experiment.
Sorry for the confusion!
Happy hacking!
Christian
On 4/5/25 18:41, Mike Crowe via libmicrohttpd wrote:
Perhaps I'm missing something obvious, but I can't understand why there
appear to be two copies of at least mhd_threads.c and mhd_threads.h in the
libmicrohttpd source tree. For current Git master at
5e40455beae130dd0dd239a7a2447b88496c3be8 and in the 1.0.1 tarball I see:
$ find . -name 'mhd_threads.*'
./src/microhttpd/mhd_threads.h
./src/microhttpd/mhd_threads.c
./src/lib/mhd_threads.h
./src/lib/mhd_threads.c
It appears that the first two are the newest and in the correct location
and the last two are older versions that may have been accidentally
resurrected in:
commit 7512349b3bb7ec147195cf25864f637e1a99c569
Author: Christian Grothoff <christ...@grothoff.org>
Date: Fri Feb 9 06:09:02 2018 +0100
allow passing pf instead of just v6 flag to listen socket creation
along with many other files that don't seem to relate to the commit
message. Since that change the older versions in lib/ have been patched a
few times but still lag behind the newer versions in microhttpd/ and their
copyright years have not been updated.
I noticed this when my changes were having no effect and I realised that I
was changing the wrong file. :(
Can anyone explain what I'm misunderstanding?
Thank.
Mike.
