Dear Damon,
Dear Lawrence,

This is a good place for such patches.
Like Evgeny, I'm in principle in favor, but have also some "major" gripes:

1) It would be great if you could update the libmicrohttpd manual (in
docs/) to document the new external API function(s).  Just a few
sentences explaining the arguments and what the function does.

2) It would be good to have a simple unit test (see src/testcurl/ for
examples), especially so that we find out if basic things break on
certain platforms (given the non-portable nature of the patch).

Happy hacking!

Christian

On 1/8/21 6:14 PM, Earp, Damon N. (GSFC-619.0)[SCIENCE SYSTEMS AND
APPLICATIONS INC] via libmicrohttpd wrote:
> We've made changes to libmicrohttpd that we'd like to see integrated into the 
> project. If this isn't the appropriate forum for submitting patches please 
> let us know.

  • ... Earp, Damon N. (GSFC-619.0)[SCIENCE SYSTEMS AND APPLICATIONS INC] via libmicrohttpd
    • ... Evgeny Grin
    • ... Christian Grothoff
      • ... Earp, Damon N. (GSFC-619.0)[SCIENCE SYSTEMS AND APPLICATIONS INC] via libmicrohttpd
        • ... Earp, Damon N. (GSFC-619.0)[SCIENCE SYSTEMS AND APPLICATIONS INC] via libmicrohttpd
          • ... Evgeny Grin
            • ... Christian Grothoff

Reply via email to