Hi Christian, Many thanks for prompt action. I can confirm now, that your fix with recent change is working and TCP callbacks are being delivered as expected.
Kind regards, Daniel On Mon, 29 Oct 2018 at 19:38, Christian Grothoff <groth...@gnunet.org> wrote: > Hi Daniel, > > I did some more testing, and my previous patch required on manually > setting MHD_USE_ITC. I've now changed the code to automatically set this > option in your situation, so please try 47281241..777d5e04 > > Happy hacking! > > Christian > > On 10/26/18 2:21 PM, Daniel Bujnik wrote: > > Hi Christian, > > > > I have just had a chance to test your change. Unfortunately I have to > > say that it does not make any difference and closing notification is > > still NOT being triggered on TCP connection closure. I have tested with > > current master. > > Please let me know if you have any other idea on how to fix it. > > > > Kind regards, > > Daniel > > > > > > On Sat, 20 Oct 2018 at 11:46, Christian Grothoff <groth...@gnunet.org > > <mailto:groth...@gnunet.org>> wrote: > > > > Dear Daniel, > > > > You didn't mention which thread mode you were using, but manual > > inspection suggests your issue should occur in thread-per-connection > > modes (only). In that case, I've pushed a (likely) fix in > > b55cd46b..47281241 to Git master. > > > > Please test and report back! > > > > Happy hacking! > > > > Christian > > > > On 10/19/2018 03:53 PM, Daniel Bujnik wrote: > > > Hello, > > > > > > I am using libmicrohttpd with MHD_OPTION_NOTIFY_CONNECTION > > parameter to > > > receive notifications for TCP connection opening/closing. > > Notifications > > > for opening case are coming through as expected, however I am > > > experiencing problems with closing case, where I am NOT getting the > > > callback when my client terminates, though I can see client FIN > packet > > > in tcpdump on the server side and connection stops appearing in > > netstat. > > > > > > Eventually the closing notification is being delivered by > > libmicrohttpd > > > but that is just after a new TCP connection is opened. The > sequence of > > > callbacks I am seeing is as followed: > > > > > > 1) callback with MHD_CONNECTION_NOTIFY_STARTED - TCP connection A > > opened > > > 2) callback with MHD_CONNECTION_NOTIFY_STARTED - new TCP > > connection B is > > > opened > > > 3) callback with MHD_CONNECTION_NOTIFY_CLOSED - TCP connection A > > closed > > > > > > Of course I would expect nr 3 to come before nr 2. I am using nc to > > > open/close sockets on client end. > > > > > > I would appreciate any comments on the described issue. Is that > > behavior > > > correct? If not is there a way to make it right? > > > > > > Kind regards, > > > Daniel > > > > > > >
