On Mon, Jul 24, 2023 at 11:58:32AM +0200, Laszlo Ersek wrote: > On 7/21/23 18:08, Eric Blake wrote: > > One of the benefits of extended replies is that we can do a > > fixed-length read for the entire header of every server reply, which > > is fewer syscalls than the split-read approach required by structured > > replies. But one of the drawbacks of doing a large read is that if > > the server is non-compliant (not a problem for normal servers, but > > something I hit rather more than I'd like to admit while developing > > extended header support in servers), nbd_pwrite() and friends will > > deadlock if the server replies with the wrong header. Add in some > > code to catch that failure mode and move the state machine to DEAD > > sooner, to make it easier to diagnose the fault in the server. ... > > Acked-by: Laszlo Ersek <ler...@redhat.com>
This part of the v4 series is now committed as dbe62a54..5c2fc3cc; I'll continue working on addressing the rest of your comments on the remainder of the v3 series. -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org _______________________________________________ Libguestfs mailing list Libguestfs@redhat.com https://listman.redhat.com/mailman/listinfo/libguestfs
