On Fri, Feb 24, 2023 at 05:39:32AM +0100, Laszlo Ersek wrote: > This reworks the single > > [libnbd PATCH v3 05/29] vector: (mostly) factor out DEFINE_VECTOR_EMPTY > > 20230215141158.2426855-6-lersek@redhat.com">http://mid.mail-archive.com/20230215141158.2426855-6-lersek@redhat.com > > according to the review comments I received from Eric and Rich in that > subthread. > > Clearly, the more closely I look at anything, the more refactoring > opportunities emerge. :/ At least, although I didn't like the amount of > work needed, I quite like the results. :) > > This series too is bisectable. > > Laszlo > > Laszlo Ersek (5): > common/include: add TYPE_IS_POINTER() macro > common/include: extract STATIC_ASSERT() macro > remove semicolon after DEFINE_VECTOR_TYPE() macro invocations > vector: introduce DEFINE_POINTER_VECTOR_TYPE() > convert string_vector_(iter(free) + reset()) to string_vector_empty()
And turned out very nicely in my opinion. See my comments on 3. For 1,2,4,5: Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org _______________________________________________ Libguestfs mailing list Libguestfs@redhat.com https://listman.redhat.com/mailman/listinfo/libguestfs
