On Fri, Feb 17, 2023 at 10:54:26AM -0600, Eric Blake wrote: > On Thu, Feb 16, 2023 at 03:23:51PM +0000, Richard W.M. Jones wrote: > > See-also: > > https://listman.redhat.com/archives/libguestfs/2023-February/030730.html > > Fixes: commit 6ef5837e2d8c5d4d83eff51c0201eb2e08f719de > > Thanks: Laszlo Ersek > > --- > > python/handle.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/python/handle.c b/python/handle.c > > index bf639b5789..717eee83ed 100644 > > --- a/python/handle.c > > +++ b/python/handle.c > > @@ -136,6 +136,7 @@ guestfs_int_py_event_callback_wrapper (guestfs_h *g, > > buf, buf_len, py_array); > > if (args == NULL) { > > PyErr_PrintEx (0); > > + Py_DECREF (py_array); > > goto out; > > } > > See my response in the other thread. You are also leaking args, which > is not fixed here. I think the correct sequence is: > > py_array = ... > args = Py_BuildValue("...O", py_array); > Py_DECREF (py_array); > if (args == NULL) { > PyErr_PrintEx (0); > goto out; > } > > ... > out: > Py_DECREF (args);
Garbage collection FTW. I'll respin this again, thanks. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW _______________________________________________ Libguestfs mailing list Libguestfs@redhat.com https://listman.redhat.com/mailman/listinfo/libguestfs
