what the heck, I'm just noticing I had sent this to Rich only earlier,
and not to the list! Resending.

FWIW, Rich had accepted my argument (also in an off-list message -- but
that's totally my fault; I had gone off-list first)

Laszlo.

On 1/30/23 19:12, Richard W.M. Jones wrote:
> On Mon, Jan 30, 2023 at 03:22:19PM +0100, Laszlo Ersek wrote:
>> +      ConfigStringList->new(name => 'misc'),
>>      ],
>>    ),
>>  ];
>> @@ -168,6 +169,7 @@ my @cmdline_aliases = (
>>    ["p2v.output.connection", "p2v.oc"],
>>    ["p2v.output.format",     "p2v.of"],
>>    ["p2v.output.storage",    "p2v.os"],
>> +  ["p2v.output.misc",       "p2v.oo"],
> 
> I'm perhaps being fussy but shouldn't it be "p2v.output.options"?
> (It doesn't really matter, just preference)

I had pondered that for an unreasonably long time :), and then I decided
against it. My thinking was, "output.connection" and "output.format" and
"output.storage" were already output options. So "output.options" felt
like "other output option options". So I stuck with "misc".

The second "o" in "-oo" can be read as "-o<other>", not necessarily as
"-o<options>", so the second "o" in "-oo" didn't convince me otherwise.

I can rename the field if you feel strongly about it. I'd rather like
not to, TBH; it's going to create a bunch of conflicts, and, again, the
other options that aren't called "options" are still options.

Laszlo
_______________________________________________
Libguestfs mailing list
Libguestfs@redhat.com
https://listman.redhat.com/mailman/listinfo/libguestfs

Reply via email to