On Mon, Jan 16, 2023 at 01:04:03PM +0100, Martin Kletzander wrote: > On Fri, Jan 13, 2023 at 08:23:05PM +0000, Richard W.M. Jones wrote: > > On Fri, Jan 13, 2023 at 01:06:09PM -0700, alan somers wrote: > > > Which files get overwritten by libvirt-ci ? > > > > I think it's everything except ci/manifest.yml, possibly. > > Eric and Martin (CC'd) know more about this. > > > > The libvirt-ci page is: > > https://libvirt.org/ci.html > > > > And the command I use to regenerate everything is: > > ../libvirt-ci/bin/lcitool manifest ci/manifest.yml > > > > I came back, went through the thread and upstream MRs and here are some > things I came up with: > > The predicates crate since version 1.0.4 do not support rust older than > 1.60.0, so it should be decided whether nbdkit wants to support > DebianĀ 11, whether nbdkit wants to support the rust plugin on systems > with older rust versions and so on. Based on that decision there are > ways to fix this issue. > > Not supporting Debian 11 is easy to achieve, of course, but probably not > wanted. > > Not supporting older rust would just need disabling rust plugin builds > with old rust in configure.ac and then on those specific systems in CI. > > If you want to make this work in all currently tested scenarios, then I > guess adding: > > predicates-core = "=1.0.3" > predicates-tree = "=1.0.3" > > to the [dev-dependencies] in Cargo.toml. That would however be > applicable to all systems and necessitate future update(s). > > If you want to do something in the CI then the easiest place is > ci/build.sh. For Cirrus CI I think it could be erased since most of it > is also checked elsewhere, although not all things have been migrated to > the other CI solution, like clippy, if I am correct. >
What would be the thing you're suggesting for ci/build.sh? It's merely calling configure and then make, so as long as the Rust build needs to be addressed, then ci/build.sh isn't the place as it's only supposed to automate some build steps not fix them IIUC. Erik _______________________________________________ Libguestfs mailing list Libguestfs@redhat.com https://listman.redhat.com/mailman/listinfo/libguestfs