- Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2124538
- Based on: [p2v PATCH 0/4] fix crash in "v2v_version" string lifecycle management https://listman.redhat.com/archives/libguestfs/2022-September/029869.html Message-Id: <20220911142501.18230-1-ler...@redhat.com> The first 13 patches are (mainly) refactorings and (occasionally) fixes for small warts. Patch#14 introduces a "Refresh disks" button, and extends the manual accordingly. Patch#15 adds a new section to the manual ("ACCESSING ISCSI DEVICES") which explains how to set up iSCSI LUNs from the XTerm / shell window, and how to expose the new /dev/sdX block device nodes to the running virt-p2v process with the "Refresh disks" button. Actual conversion of a physical Windows 2022 installation, from an iSCSI OS disk, tested by Vera Wu in <https://bugzilla.redhat.com/show_bug.cgi?id=2124538#c19>. Laszlo Laszlo Ersek (15): set_from_ui_generic(): eliminate small code duplication set_interfaces_from_ui(): open-code the set_from_ui_generic() logic gui.c: consume "all_disks" and "all_removables" only for dialog setup compare(): move to "utils.c", rename to compare_strings() find_all_disks(): extract (plus friends) to new file "disks.c" find_all_disks(): minimize global variable references populate_disks(), populate_removable(): minimize references to globals set_config_defaults(): clean up some warts set_config_defaults(): hoist find_all_disks() call to main() gui.c: remove "all_disks" and "all_removable" global variable references "all_disks", "all_removable": eliminate gui.c: extract GtkListStore-filling loops for "disks" and "removable" create_conversion_dialog(): make "start_button" local create_conversion_dialog(): add button to refresh disks & removables virt-p2v.pod: explain how to bring iSCSI LUNs to the disk selection dialog Makefile.am | 1 + disks.c | 186 +++++++++++ gui.c | 330 ++++++++++++++------ main.c | 226 ++------------ p2v.h | 14 +- utils.c | 8 + virt-p2v.pod | 119 ++++++- 7 files changed, 579 insertions(+), 305 deletions(-) create mode 100644 disks.c _______________________________________________ Libguestfs mailing list Libguestfs@redhat.com https://listman.redhat.com/mailman/listinfo/libguestfs
