On Fri, Dec 03, 2021 at 01:56:02PM -0600, Eric Blake wrote: > On Fri, Dec 03, 2021 at 07:38:49PM +0000, Richard W.M. Jones wrote: > > > > Alas, generator/states.c. Here's how I tested. In particular, note > > > that you MUST use an off-by-one #line directive for the current file > > > (the directive #line 10 must appear on line 9, for gdb to display the > > > code at line 10 on the next step of the program). > > > > In that case, patch 3 needs something like: > > > > - let output_loc = "lib/states.c", output_lineno () in > > + let output_loc = "lib/states.c", output_lineno () + 1 in > > Yep, with that change, my gdb session single-stepping through the > state machine lines up with the code being executed. ACK series, and > thanks for tackling this!
I pushed this as commits 38ce5836aa and f78ef5647d. The second commit contains patches 2 & 3 squashed together (plus extra fix) because that seemed to make more sense. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW _______________________________________________ Libguestfs mailing list Libguestfs@redhat.com https://listman.redhat.com/mailman/listinfo/libguestfs
