On Wed, Mar 23, 2016 at 09:36:02PM +0300, Roman Kagan wrote: > On Wed, Mar 23, 2016 at 09:27:43AM +0000, Richard W.M. Jones wrote: > > On Fri, Mar 18, 2016 at 07:15:35PM +0300, Roman Kagan wrote: > > > Those will be useful when making decisions about what configuration to > > > set on output. > > > > > > The data is also included in --print-source so the tests are adjusted > > > accordingly. > > > > This patch seems to cause the tests in v2v/ to fail. > > All v2v tests pass for me. Could you please provide the logs to > investigate?
Attached. The patches are fine to push as long as: - replace 5/5 with my copyedited version - fix the test failure Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html
============================================ libguestfs 1.33.15: v2v/test-suite.log ============================================ # TOTAL: 25 # PASS: 24 # SKIP: 0 # XFAIL: 0 # FAIL: 1 # XPASS: 0 # ERROR: 0 .. contents:: :depth: 2 FAIL: test-v2v-print-source.sh ============================== ./test-v2v-print-source.sh: unexpected output from test: [ 0.0] Opening the source -i libvirt -ic test:///home/rjones/d/libguestfs/test-data/phony-guests/guests.xml windows Source guest information (--print-source option): source name: windows hypervisor type: test memory: 1073741824 (bytes) nr vCPUs: 1 CPU features: firmware: unknown display: video: sound: disks: /home/rjones/d/libguestfs/test-data/phony-guests/windows.img (raw) [virtio] removable media: NICs: FAIL test-v2v-print-source.sh (exit status: 1)
_______________________________________________ Libguestfs mailing list Libguestfs@redhat.com https://www.redhat.com/mailman/listinfo/libguestfs