Thanks for doing the work and for merging. I just ran "make distcheck" (building outside of source directory from a tarball) and I get a couple of failures:
... FAIL: check_multiextent.sh PASS: check_fuzzyiso.sh PASS: check_opts.sh FAIL: check_deep_directory.sh >From check_deep_directory.sh.log: -- ../../../test/check_deep_directory.sh: Deep directory listing test ok. /usr/bin/diff: ../../../test/data/deep_directory1_file: No such file or directory ../../../test/check_deep_directory.sh: Deep directory read test level 8 failed. ../../../test/check_deep_directory.sh: failed command: ../src/iso-info ../src/iso-read --ignore --image ../../../test/data/deep-directory.iso --extract 1/2/3/4/5/6/7/8/8.txt FAIL check_deep_directory.sh (exit status: 3) And from check_multiextent.sh.sh: -- ../../../test/check_multiextent.sh: Multiextent listing test ok. /usr/bin/diff: ../../../test/data/multi_extent_file: No such file or directory ../../../test/check_multiextent.sh: Multiextent read test failed. ../../../test/check_multiextent.sh: failed command: ../src/iso-info ../src/iso-read --ignore --image ../../../test/data/multi_extent_8k.iso --extract multi_extent_file FAIL check_multiextent.sh (exit status: 3) I think those new files mentioned need to be added to the check_DATA variable test/data/Makefile.am. If we want to assume GNU make will be used to build, then a more robust way to handle this is to use the GNU make wildcard function. On Wed, Jun 17, 2020 at 2:23 PM Pete Batard <pbat...@gmail.com> wrote: > Okay, I have just merged the proposal to mainline, with Thomas' proposed > improvement. > > I validated that the test suite passed for both Windows/MinGW and Linux, > but of course, feel free to confirm that you don't see any issues. > > Regards, > > /Pete > > On 2020.06.16 17:47, Thomas Schmitt wrote: > > Hi, > > > > Rocky Bernstein wrote: > >> But,Thomas, if you want to redo so it is smaller that's okay too. > > > > We tested. We discussed. Let's merge. > > > > > > Have a nice day :) > > > > Thomas > > > > > > >
