Module: libav
Branch: master
Commit: cacb62f9cbf37bb05b00a025b21904b6966b6a49
Author: James Almer <jamr...@gmail.com>
Committer: James Almer <jamr...@gmail.com>
Date: Wed Sep 12 15:21:09 2018 -0300
Revert "decode: copy the output parameters from the last bsf in the chain back
to the AVCodecContext"
This reverts commit 662558f985f50834eebe82d6b6854c66f33ab320.
The avcodec_parameters_to_context() call was freeing and reallocating
AVCodecContext->extradata, essentially taking ownership of it, which according
to the doxy is user owned. This is an API break and has produces crashes in
some library users like Firefox.
Revert until a better solution is found to internally propagate the filtered
extradata back into the decoder context.
Signed-off-by: James Almer <jamr...@gmail.com>
---
libavcodec/decode.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/libavcodec/decode.c b/libavcodec/decode.c
index d10a2c8..2dab7f2 100644
--- a/libavcodec/decode.c
+++ b/libavcodec/decode.c
@@ -221,10 +221,6 @@ int ff_decode_bsfs_init(AVCodecContext *avctx)
goto fail;
}
- ret = avcodec_parameters_to_context(avctx, s->bsfs[s->nb_bsfs -
1]->par_out);
- if (ret < 0)
- return ret;
-
return 0;
fail:
ff_decode_bsfs_uninit(avctx);
_______________________________________________
libav-commits mailing list
libav-commits@libav.org
https://lists.libav.org/mailman/listinfo/libav-commits
