Jeremy Huntwork wrote:
Robert Connolly wrote:
There are now 5 patches in:
http://ftp.gnu.org/gnu/bash/bash-3.2-patches/
Maybe its worth combining them.
Indeed.
I have a patch sitting around that does just this. Unfortunately, with
a 6-hour build time real life often gets in the way of having these
things tested. Here it is though.
Regards,
Matt.
Index: LFS-trunk/general.ent
===================================================================
--- LFS-trunk.orig/general.ent 2006-11-12 18:08:56.000000000 +0000
+++ LFS-trunk/general.ent 2006-11-12 18:10:14.000000000 +0000
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="ISO-8859-1"?>
-<!ENTITY version "SVN-20061110">
-<!ENTITY releasedate "November 10, 2006">
+<!ENTITY version "SVN-20061112">
+<!ENTITY releasedate "November 12, 2006">
<!ENTITY milestone "6.3">
<!ENTITY generic-version "development"> <!-- Use "development", "testing", or "x.y[-pre{x}]" -->
Index: LFS-trunk/patches.ent
===================================================================
--- LFS-trunk.orig/patches.ent 2006-10-29 18:16:52.000000000 +0000
+++ LFS-trunk/patches.ent 2006-11-12 18:11:27.000000000 +0000
@@ -1,9 +1,9 @@
<?xml version="1.0" encoding="ISO-8859-1"?>
<!-- Start of Common Patches -->
-<!ENTITY bash-comment-patch "bash-&bash-version;-parse_comment-1.patch">
-<!ENTITY bash-comment-patch-md5 "6420d890711431ebeb63b5a9f3d9764d">
-<!ENTITY bash-comment-patch-size "1.5 KB">
+<!ENTITY bash-fixes-patch "bash-&bash-version;-fixes-1.patch">
+<!ENTITY bash-fixes-patch-md5 "541834ceb90f4f3eee45cee246cc2cc4">
+<!ENTITY bash-fixes-patch-size "9.9 KB">
<!ENTITY bzip2-bzgrep-patch "bzip2-&bzip2-version;-bzgrep_security-1.patch">
Index: LFS-trunk/chapter01/changelog.xml
===================================================================
--- LFS-trunk.orig/chapter01/changelog.xml 2006-11-12 18:08:33.000000000 +0000
+++ LFS-trunk/chapter01/changelog.xml 2006-11-12 18:13:02.000000000 +0000
@@ -37,6 +37,16 @@
-->
<listitem>
+ <para>2006-11-12</para>
+ <itemizedlist>
+ <listitem>
+ <para>[matthew] - Use all 5 of the patches currently supplied by
+ the upstream maintainers of Bash.</para>
+ </listitem>
+ </itemizedlist>
+ </listitem>
+
+ <listitem>
<para>2006-11-10</para>
<itemizedlist>
<listitem>
Index: LFS-trunk/chapter01/whatsnew.xml
===================================================================
--- LFS-trunk.orig/chapter01/whatsnew.xml 2006-10-29 18:06:35.000000000 +0000
+++ LFS-trunk/chapter01/whatsnew.xml 2006-11-12 18:13:19.000000000 +0000
@@ -202,7 +202,7 @@
<title>Added:</title>
<listitem>
- <para>&bash-comment-patch;</para>
+ <para>&bash-fixes-patch;</para>
</listitem>
<listitem>
<para>&less-signal_fix-patch;</para>
Index: LFS-trunk/chapter03/patches.xml
===================================================================
--- LFS-trunk.orig/chapter03/patches.xml 2006-10-29 18:03:38.000000000 +0000
+++ LFS-trunk/chapter03/patches.xml 2006-11-12 18:14:15.000000000 +0000
@@ -19,10 +19,10 @@
<variablelist role="materials">
<varlistentry>
- <term>Bash Comment Parser Patch - <token>&bash-comment-patch-size;</token>:</term>
+ <term>Bash Comment Parser Patch - <token>&bash-fixes-patch-size;</token>:</term>
<listitem>
- <para>Download: <ulink url="&patches-root;&bash-comment-patch;"/></para>
- <para>MD5 sum: <literal>&bash-comment-patch-md5;</literal></para>
+ <para>Download: <ulink url="&patches-root;&bash-fixes-patch;"/></para>
+ <para>MD5 sum: <literal>&bash-fixes-patch-md5;</literal></para>
</listitem>
</varlistentry>
Index: LFS-trunk/chapter05/bash.xml
===================================================================
--- LFS-trunk.orig/chapter05/bash.xml 2006-10-28 23:08:13.000000000 +0100
+++ LFS-trunk/chapter05/bash.xml 2006-11-12 18:15:12.000000000 +0000
@@ -37,10 +37,10 @@
<sect2 role="installation">
<title>Installation of Bash</title>
- <para>Apply a fix for a bug that causes some comments to be parsed
- incorrectly:</para>
+ <para>Apply fixes for several bugs discovered since the initial release of
+ Bash-&bash-version;:</para>
-<screen><userinput>patch -Np1 -i ../&bash-comment-patch;</userinput></screen>
+<screen><userinput>patch -Np1 -i ../&bash-fixes-patch;</userinput></screen>
<para>Prepare Bash for compilation:</para>
Index: LFS-trunk/chapter06/bash.xml
===================================================================
--- LFS-trunk.orig/chapter06/bash.xml 2006-10-28 23:08:13.000000000 +0100
+++ LFS-trunk/chapter06/bash.xml 2006-11-12 18:15:33.000000000 +0000
@@ -41,10 +41,10 @@
sed -i "s|htmldir = @htmldir@|htmldir = /usr/share/doc/bash-&bash-version;|" \
Makefile.in</userinput></screen>
- <para>Apply a fix for a bug that causes some comments to be parsed
- incorrectly:</para>
+ <para>Apply fixes for several bugs discovered since the initial release of
+ Bash-&bash-version;:</para>
-<screen><userinput>patch -Np1 -i ../&bash-comment-patch;</userinput></screen>
+<screen><userinput>patch -Np1 -i ../&bash-fixes-patch;</userinput></screen>
<para>Prepare Bash for compilation:</para>
Submitted By: Matt Burgess (matthew at linuxfromscratch dot org)
Date: 2006-11-12
Initial Package Version: 3.2
Upstream Status: From Upstream
Origin: http://ftp.gnu.org/gnu/bash/bash-3.2-patches/
Description: A combined patch containing patches 001-005 from upstream.
diff -Naur bash-3.2.orig/builtins/printf.def bash-3.2/builtins/printf.def
--- bash-3.2.orig/builtins/printf.def 2006-09-18 12:48:42.000000000 +0000
+++ bash-3.2/builtins/printf.def 2006-11-12 18:06:00.000000000 +0000
@@ -49,6 +49,12 @@
# define INT_MIN (-2147483647-1)
#endif
+#if defined (PREFER_STDARG)
+# include <stdarg.h>
+#else
+# include <varargs.h>
+#endif
+
#include <stdio.h>
#include <chartypes.h>
@@ -151,6 +157,10 @@
#define SKIP1 "#'-+ 0"
#define LENMODS "hjlLtz"
+#ifndef HAVE_ASPRINTF
+extern int asprintf __P((char **, const char *, ...)) __attribute__((__format__ (printf, 2, 3)));
+#endif
+
static void printf_erange __P((char *));
static int printstr __P((char *, char *, int, int, int));
static int tescape __P((char *, char *, int *));
diff -Naur bash-3.2.orig/lib/sh/snprintf.c bash-3.2/lib/sh/snprintf.c
--- bash-3.2.orig/lib/sh/snprintf.c 2006-04-06 13:48:40.000000000 +0000
+++ bash-3.2/lib/sh/snprintf.c 2006-11-12 18:06:00.000000000 +0000
@@ -471,6 +471,8 @@
10^x ~= r
* log_10(200) = 2;
* log_10(250) = 2;
+ *
+ * NOTE: do not call this with r == 0 -- an infinite loop results.
*/
static int
log_10(r)
@@ -576,8 +578,11 @@
{
integral_part[0] = '0';
integral_part[1] = '\0';
- fraction_part[0] = '0';
- fraction_part[1] = '\0';
+ /* The fractional part has to take the precision into account */
+ for (ch = 0; ch < precision-1; ch++)
+ fraction_part[ch] = '0';
+ fraction_part[ch] = '0';
+ fraction_part[ch+1] = '\0';
if (fract)
*fract = fraction_part;
return integral_part;
@@ -805,6 +810,7 @@
PUT_CHAR(*tmp, p);
tmp++;
}
+
PAD_LEFT(p);
}
@@ -972,11 +978,21 @@
if ((p->flags & PF_THOUSANDS) && grouping && (t = groupnum (tmp)))
tmp = t;
+ if ((*p->pf == 'g' || *p->pf == 'G') && (p->flags & PF_ALTFORM) == 0)
+ {
+ /* smash the trailing zeros unless altform */
+ for (i = strlen(tmp2) - 1; i >= 0 && tmp2[i] == '0'; i--)
+ tmp2[i] = '\0';
+ if (tmp2[0] == '\0')
+ p->precision = 0;
+ }
+
/* calculate the padding. 1 for the dot */
p->width = p->width -
((d > 0. && p->justify == RIGHT) ? 1:0) -
((p->flags & PF_SPACE) ? 1:0) -
- strlen(tmp) - p->precision - 1;
+ strlen(tmp) - p->precision -
+ ((p->precision != 0 || (p->flags & PF_ALTFORM)) ? 1 : 0); /* radix char */
PAD_RIGHT(p);
PUT_PLUS(d, p, 0.);
PUT_SPACE(d, p, 0.);
@@ -991,11 +1007,6 @@
if (p->precision != 0 || (p->flags & PF_ALTFORM))
PUT_CHAR(decpoint, p); /* put the '.' */
- if ((*p->pf == 'g' || *p->pf == 'G') && (p->flags & PF_ALTFORM) == 0)
- /* smash the trailing zeros unless altform */
- for (i = strlen(tmp2) - 1; i >= 0 && tmp2[i] == '0'; i--)
- tmp2[i] = '\0';
-
for (; *tmp2; tmp2++)
PUT_CHAR(*tmp2, p); /* the fraction */
@@ -1011,14 +1022,19 @@
char *tmp, *tmp2;
int j, i;
- if (chkinfnan(p, d, 1) || chkinfnan(p, d, 2))
+ if (d != 0 && (chkinfnan(p, d, 1) || chkinfnan(p, d, 2)))
return; /* already printed nan or inf */
GETLOCALEDATA(decpoint, thoussep, grouping);
DEF_PREC(p);
- j = log_10(d);
- d = d / pow_10(j); /* get the Mantissa */
- d = ROUND(d, p);
+ if (d == 0.)
+ j = 0;
+ else
+ {
+ j = log_10(d);
+ d = d / pow_10(j); /* get the Mantissa */
+ d = ROUND(d, p);
+ }
tmp = dtoa(d, p->precision, &tmp2);
/* 1 for unit, 1 for the '.', 1 for 'e|E',
@@ -1076,6 +1092,7 @@
PUT_CHAR(*tmp, p);
tmp++;
}
+
PAD_LEFT(p);
}
#endif
@@ -1358,7 +1375,7 @@
STAR_ARGS(data);
DEF_PREC(data);
d = GETDOUBLE(data);
- i = log_10(d);
+ i = (d != 0.) ? log_10(d) : -1;
/*
* for '%g|%G' ANSI: use f if exponent
* is in the range or [-4,p] exclusively
diff -Naur bash-3.2.orig/parse.y bash-3.2/parse.y
--- bash-3.2.orig/parse.y 2006-09-19 20:37:21.000000000 +0000
+++ bash-3.2/parse.y 2006-11-12 18:05:57.000000000 +0000
@@ -1029,6 +1029,7 @@
#define PST_CMDTOKEN 0x1000 /* command token OK - unused */
#define PST_COMPASSIGN 0x2000 /* parsing x=(...) compound assignment */
#define PST_ASSIGNOK 0x4000 /* assignment statement ok in this context */
+#define PST_REGEXP 0x8000 /* parsing an ERE/BRE as a single word */
/* Initial size to allocate for tokens, and the
amount to grow them by. */
@@ -2591,6 +2592,9 @@
return (character);
}
+ if (parser_state & PST_REGEXP)
+ goto tokword;
+
/* Shell meta-characters. */
if MBTEST(shellmeta (character) && ((parser_state & PST_DBLPAREN) == 0))
{
@@ -2698,6 +2702,7 @@
if MBTEST(character == '-' && (last_read_token == LESS_AND || last_read_token == GREATER_AND))
return (character);
+tokword:
/* Okay, if we got this far, we have to read a word. Read one,
and then check it against the known ones. */
result = read_token_word (character);
@@ -2735,7 +2740,7 @@
/* itrace("parse_matched_pair: open = %c close = %c", open, close); */
count = 1;
pass_next_character = backq_backslash = was_dollar = in_comment = 0;
- check_comment = (flags & P_COMMAND) && qc != '\'' && qc != '"' && (flags & P_DQUOTE) == 0;
+ check_comment = (flags & P_COMMAND) && qc != '`' && qc != '\'' && qc != '"' && (flags & P_DQUOTE) == 0;
/* RFLAGS is the set of flags we want to pass to recursive calls. */
rflags = (qc == '"') ? P_DQUOTE : (flags & P_DQUOTE);
@@ -3202,8 +3207,11 @@
if (tok == WORD && test_binop (yylval.word->word))
op = yylval.word;
#if defined (COND_REGEXP)
- else if (tok == WORD && STREQ (yylval.word->word,"=~"))
- op = yylval.word;
+ else if (tok == WORD && STREQ (yylval.word->word, "=~"))
+ {
+ op = yylval.word;
+ parser_state |= PST_REGEXP;
+ }
#endif
else if (tok == '<' || tok == '>')
op = make_word_from_token (tok); /* ( */
@@ -3234,6 +3242,7 @@
/* rhs */
tok = read_token (READ);
+ parser_state &= ~PST_REGEXP;
if (tok == WORD)
{
tright = make_cond_node (COND_TERM, yylval.word, (COND_COM *)NULL, (COND_COM *)NULL);
@@ -3419,9 +3428,34 @@
goto next_character;
}
+#ifdef COND_REGEXP
+ /* When parsing a regexp as a single word inside a conditional command,
+ we need to special-case characters special to both the shell and
+ regular expressions. Right now, that is only '(' and '|'. */ /*)*/
+ if MBTEST((parser_state & PST_REGEXP) && (character == '(' || character == '|')) /*)*/
+ {
+ if (character == '|')
+ goto got_character;
+
+ push_delimiter (dstack, character);
+ ttok = parse_matched_pair (cd, '(', ')', &ttoklen, 0);
+ pop_delimiter (dstack);
+ if (ttok == &matched_pair_error)
+ return -1; /* Bail immediately. */
+ RESIZE_MALLOCED_BUFFER (token, token_index, ttoklen + 2,
+ token_buffer_size, TOKEN_DEFAULT_GROW_SIZE);
+ token[token_index++] = character;
+ strcpy (token + token_index, ttok);
+ token_index += ttoklen;
+ FREE (ttok);
+ dollar_present = all_digit_token = 0;
+ goto next_character;
+ }
+#endif /* COND_REGEXP */
+
#ifdef EXTENDED_GLOB
/* Parse a ksh-style extended pattern matching specification. */
- if (extended_glob && PATTERN_CHAR (character))
+ if MBTEST(extended_glob && PATTERN_CHAR (character))
{
peek_char = shell_getc (1);
if MBTEST(peek_char == '(') /* ) */
diff -Naur bash-3.2.orig/patchlevel.h bash-3.2/patchlevel.h
--- bash-3.2.orig/patchlevel.h 2006-04-13 12:31:04.000000000 +0000
+++ bash-3.2/patchlevel.h 2006-11-12 18:06:00.000000000 +0000
@@ -25,6 +25,6 @@
regexp `^#define[ ]*PATCHLEVEL', since that's what support/mkversion.sh
looks for to find the patch level (for the sccs version string). */
-#define PATCHLEVEL 0
+#define PATCHLEVEL 5
#endif /* _PATCHLEVEL_H_ */
diff -Naur bash-3.2.orig/po/ru.po bash-3.2/po/ru.po
--- bash-3.2.orig/po/ru.po 2006-01-10 22:51:03.000000000 +0000
+++ bash-3.2/po/ru.po 2006-11-12 18:05:56.000000000 +0000
@@ -12,7 +12,7 @@
"Last-Translator: Evgeniy Dushistov <[EMAIL PROTECTED]>\n"
"Language-Team: Russian <[EMAIL PROTECTED]>\n"
"MIME-Version: 1.0\n"
-"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Type: text/plain; charset=KOI8-R\n"
"Content-Transfer-Encoding: 8bit\n"
"Plural-Forms: nplurals=3; plural=(n%10==1 && n%100!=11 ? 0 : n%10>=2 && n%10<=4 && (n%100<10 || n%100>=20) ? 1 : 2);\n"
diff -Naur bash-3.2.orig/subst.c bash-3.2/subst.c
--- bash-3.2.orig/subst.c 2006-09-19 12:35:09.000000000 +0000
+++ bash-3.2/subst.c 2006-11-12 18:05:58.000000000 +0000
@@ -5707,6 +5707,11 @@
vtype &= ~VT_STARSUB;
mflags = 0;
+ if (patsub && *patsub == '/')
+ {
+ mflags |= MATCH_GLOBREP;
+ patsub++;
+ }
/* Malloc this because expand_string_if_necessary or one of the expansion
functions in its call chain may free it on a substitution error. */
@@ -5741,13 +5746,12 @@
}
/* ksh93 doesn't allow the match specifier to be a part of the expanded
- pattern. This is an extension. */
+ pattern. This is an extension. Make sure we don't anchor the pattern
+ at the beginning or end of the string if we're doing global replacement,
+ though. */
p = pat;
- if (pat && pat[0] == '/')
- {
- mflags |= MATCH_GLOBREP|MATCH_ANY;
- p++;
- }
+ if (mflags & MATCH_GLOBREP)
+ mflags |= MATCH_ANY;
else if (pat && pat[0] == '#')
{
mflags |= MATCH_BEG;
diff -Naur bash-3.2.orig/tests/new-exp.right bash-3.2/tests/new-exp.right
--- bash-3.2.orig/tests/new-exp.right 2006-08-10 16:00:00.000000000 +0000
+++ bash-3.2/tests/new-exp.right 2006-11-12 18:05:58.000000000 +0000
@@ -430,7 +430,7 @@
Case06---1---A B C::---
Case07---3---A:B:C---
Case08---3---A:B:C---
-./new-exp.tests: line 506: /${$(($#-1))}: bad substitution
+./new-exp.tests: line 506: ${$(($#-1))}: bad substitution
argv[1] = <a>
argv[2] = <b>
argv[3] = <c>
--
http://linuxfromscratch.org/mailman/listinfo/lfs-dev
FAQ: http://www.linuxfromscratch.org/faq/
Unsubscribe: See the above information page
