Bryan Kadzban wrote:
> On Fri, Sep 22, 2006 at 05:55:24PM +0600, Alexander E. Patrakov 
> wrote:
> 
>>> I wasn't sure if the disk was actually on the "ancestor" chain of
>>> the partition, so I left it as-is instead of converting to 
>>> ATTRS{removable}.
>>> 
>>> It should probably be changed to the upstream version though.
>> 
>> Test and report.
> 
> Will do, if I have any devices that show up with 
> ATTR{removable}=="1". I can probably tell from udevinfo whether the 
> whole-disk device is a parent of the partition device, though.  (And 
> from Kay's response on linux-hotplug-devel, it sounds like it is.)

OK.  I did a "udevinfo -a -p /block/hda/hda1".  My hda is an internal
IDE drive.

udevinfo showed no "removable" attribute on hda1, but it did show it on
hda (which *was* hda1's parent).  So ATTRS{removable} for partition
devices should work the same way that ATTR{../removable} would.

>>> Do you know if ATTRS{ieee1394_id}=="*" matches if the ieee1394_id
>>> attribute is missing entirely?
>> 
>> It doesn't.
> 
> 
> That's good to know, thanks.  So do you think it should be OK to 
> leave it as "*", to match any device that has an _id attribute, even 
> if that attribute is empty?

It seems (from linux-hotplug-devel) that this may have been a typo in
their rule, so I'll leave ours as-is.  (With the "?*" string.)

>> Anyway, Kay already gave his opinion on linux-hotplug-devel: 
>> "KERNEL=="hd*[!0-9]", ATTRS{removable}=="1" could be ATTR I think, 
>> cause it will not run for a partition anyway cause of the KERNEL 
>> match."
> 
> 
> Yep, I saw that.  I'll change that later today.
> 
> 
>>> As far as 95-udev-late goes:  That's just for udevmonitor, 
>>> correct?  I think we should probably still have it, just 
>>> wondering what uses it.
>> 
>> udevmonitor is a debugging tool shipped with udev.
> 
> 
> Yes, and I think we should have a rule to enable it.

Both of these are committed in r7799.  (I also added in udev-100's
60-persistent-input.rules file.)

Attachment: signature.asc
Description: OpenPGP digital signature

-- 
http://linuxfromscratch.org/mailman/listinfo/lfs-dev
FAQ: http://www.linuxfromscratch.org/faq/
Unsubscribe: See the above information page

Reply via email to