Robert Connolly wrote: > This isn't a bug, but the line: > > sed 's/^XCFLAGS =$/& -fomit-frame-pointer/' > > can be problematic if a user uses this command to modify other variables, > because the -fomit-frame-pointer is appended to the end of the line. Some of > the *FLAGS in GCC end with a \ character at the end of the first line, and > this command won't work. I suggest we stop using the "$" (end-of-line) card, > and use: > > sed 's/^XCFLAGS =/& -fomit-frame-pointer/' > > so that -fomit-frame-pointer will be added as the first argument, and the sed > will work in any case.
I'd be interested in other opinions. My initial reaction is that if users apply something to a location that is not specified, they can live with the consequences. They can also learn the meaning of a sed construct through making a mistake. -- Bruce -- http://linuxfromscratch.org/mailman/listinfo/lfs-dev FAQ: http://www.linuxfromscratch.org/faq/ Unsubscribe: See the above information page
