Florian Schanda wrote:
On Monday 13 March 2006 21:56, Jeremy Huntwork wrote:
Andrew Benton wrote:
It also matches -u{8,16,32,64} and changes them to __u{8,16,32,64}
Hrm. Check this again. Are the '-u{8,16,32,64}' matches perhaps diffs of
existing lines of 'u{8,16,32,64}' being removed the better sed? I think
Jim's original seds didn't get all of them and now Florian's proposal
catches some that Jim didn't and you're seeing '-u...' in the diffs.

I am somewhat confused. I grepped for -u8 in the kernel, and found nothing... Besides, since its C we are talking about: - is a operator and can't be part of variable names or type names.

Doh! Yes, my bad, the - was from the diff, the u was at the start of the line so Florian's construct is the better one as it catches things at the start of the line, like these in <linux/ethtool.h>


/* Some generic methods drivers may use in their ethtool_ops */
u32 ethtool_op_get_link(struct net_device *dev);
u32 ethtool_op_get_tx_csum(struct net_device *dev);
int ethtool_op_set_tx_csum(struct net_device *dev, __u32 data);
int ethtool_op_set_tx_hw_csum(struct net_device *dev, __u32 data);
u32 ethtool_op_get_sg(struct net_device *dev);
int ethtool_op_set_sg(struct net_device *dev, __u32 data);
u32 ethtool_op_get_tso(struct net_device *dev);

Andy
--
http://linuxfromscratch.org/mailman/listinfo/lfs-dev
FAQ: http://www.linuxfromscratch.org/faq/
Unsubscribe: See the above information page

Reply via email to