Matthew Burgess wrote:
> Given the fairly minor changes required to get this all working, I'm not
> sure it's worth setting a branch up for this stuff.  This, of course,
> assumes I've not missed something!

Nothing major, but:

> -             # Now, create some required files/directories/devices that sysfs
> -             # doesn't export for us.
> -             make_extra_nodes
> +             # /lib/udev/devices contains device nodes for broken subsystems
> +             #  or devices which can't be detected automatically by the
> +             #  kernel.
> +             cp -R /lib/udev/devices/* /dev

Shouldn't that be "cp -a", to preserve UID/GID/permissions?

(This doesn't matter for the /dev/fd, /dev/std{in,out,err}, /dev/core
symlinks, etc., but for generic devices/directories/whatever to be
copied to /dev on startup, it does.  For instance, if a driver (outside
the kernel) creates a device node but doesn't have a GPL-compatible
license, then it will have no way to register a /sys/class or /sys/block
sysfs entry (the relevant APIs are EXPORT_SYMBOL_GPL), so it won't be
able to dynamically create its device file.  But it could still use
/lib/udev/devices, and if it did, it would want UID/GID/permissions to
be preserved during the copy.)

Attachment: signature.asc
Description: OpenPGP digital signature

-- 
http://linuxfromscratch.org/mailman/listinfo/lfs-dev
FAQ: http://www.linuxfromscratch.org/faq/
Unsubscribe: See the above information page

Reply via email to