-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Alexander E. Patrakov wrote: > When adding a "version update" comment to Bugzilla, please also add the > output of the following checker script: > > ifnames `find . -name \*.c -o -name \*.h` | grep HAVE | \ > grep -v HAVE_CONFIG_H | cut -d " " -f 1 >ifnames.hin > for a in `cat ifnames.hin` ; do if ! grep -q $a configh.in ; \ > then echo "$a is missing " ; fi ; done > > (it is OK to omit output related to files that implement missing > glibc-like functions for non-GNU systems functions that)
Hi Alexander, I suggest you use "grep ^HAVE_" instead of only "grep HAVE", so you reduce the false positives. SANE for instance use macros like "WE_HAVE_*" which I suppose are not to be listed. So here goes a slightly modified snnipet, which does not create a temp file: ifnames `find . -name \*.c -o -name \*.h` | grep ^HAVE_ | \ grep -v HAVE_CONFIG_H | cut -d" " -f1 | while read a; do \ grep -q $a config.h.in || echo "$a is missing"; done If I understand correctly the issue, if e.g. the macro HAVE_XXX is not defined on config.h, then the code sorrounded by "#ifdef HAVE_XXX ... #endif" will never get compiled (except if someone adds "-DHAVE_XXX" to CPPFLAGS), right? Might it be the case that some of this code is actually old/deprecated and just needs to be removed? After all, it's never compiled, who would need it... It might also be good to report the problems upstream where possible. - -- Anderson Lizardo [EMAIL PROTECTED] http://www.linuxfromscratch.org/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.5 (GNU/Linux) iD8DBQFC/+cukzNmn+NRHHoRAjPHAJ9YNw4fZL5XgaG4Mm5EJA/BLyEiAgCbBJje PQLbVFRkDVKns+PoFW6iT6w= =iUku -----END PGP SIGNATURE----- _______________________________________________________ Yahoo! Acesso GrАtis - Internet rАpida e grАtis. Instale o discador agora! http://br.acesso.yahoo.com/ -- http://linuxfromscratch.org/mailman/listinfo/lfs-dev FAQ: http://www.linuxfromscratch.org/faq/ Unsubscribe: See the above information page
