On Sat, Aug 24, 2024 at 7:00 PM Thomas Passin <tbp100...@gmail.com> wrote:
> It didn't do it [have the bug] several years ago.
Leo 6.7.8 was the last official version that did not suffer this bug. Leo
6.8.0 and 6.8.1 do have the bug.
I did a git bisect:
a37e1eb2af74c8d53d325325d563a30f6dc100b3 is the first bad commit
commit a37e1eb2af74c8d53d325325d563a30f6dc100b3
Author: Edward K. Ream <edream...@gmail.com>
Date: Tue Apr 23 04:44:59 2024 -0500
Fix #3809 by adding jedit.Colorize(!!)
leo/commands/commanderOutlineCommands.py | 5 ++++-
leo/core/leoColorizer.py | 11 +++++++++++
leo/core/leoFrame.py | 3 ++-
3 files changed, 17 insertions(+), 2 deletions(-)
I wouldn't bet my life that this is the culprit, but let's assume for a
moment that it is. This commit adds the following:
def colorize(self, p: Position) -> None:
"""jedit.Colorize: fully recolor p.b."""
if not p:
return
self.updateSyntaxColorer(p)
# Similar to code in jedit.recolor.
self.init_all_state(p.v)
self.init()
# Force QSyntaxHighlighter to do a full recolor.
self.highlighter.rehighlight()
Could this *new* code be the culprit? Yes, it looks like it is! The bug
disappears when I disable jedit.colorize!!
Folks, it looks like the multiple-body code has reached the point of being
impossible to understand.
Say at the time I added the freewin plugin. I didn't like the added editor
> because it was too easy to get confused about which editor instance was
> seeing which node. I kept making mistakes, typing into the wrong node.
> That influenced my design for freewin, where a FW window always stays
> locked to the same node.
>
The stickynotes plugin is similarly easy to use.
*Summary*
Leo has been solid all these years because my supreme design goal has been
to minimize unwanted dependencies between unrelated modules. But it looks
like the innocent-looking rev a37e1e broke Leo. Imo, it's time to eliminate
everything associated with the add-editor command.
Your comments, please.
Edward
--
You received this message because you are subscribed to the Google Groups
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to leo-editor+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/leo-editor/CAMF8tS1vv-%2B%2B_AOu-_7Tq-ZwxUNbukZ48qm3Jrt_T4New5CN5Q%40mail.gmail.com.
