I'm glad we've had the conversation about cut-node/paste-node. It reminded me of something that has been bothering me subconsciously.
The diffs for PR #3215 <https://github.com/leo-editor/leo-editor/pull/3215/files> show that the gnx changed for p.get_GNX, renamed. - #@+node:tbrown.20111010104549.26758: *4* p.get_UNL + #@+node:ekr.20230628174317.1: *5* p.get_full_gnx_UNL How did I discover this, you ask? How did I know to look for this diff? The answer is simple: Weeks ago, Leo's git-diff-pr command showed that I had deleted p.get_UNL and then added p.get_UNL. This kind of diff is the classic symptom of cut-node/paste-node. The reason I did the cut/paste of this node is interesting, but not interesting enough to tell here :-) The tweak PR, #3424 <https://github.com/leo-editor/leo-editor/pull/3424>, will fix this misattribution. Terry deserves all the credit(??) for this method. *Summary* Leo's devs (and *only *devs) should beware when Leo's git-diff or git-diff-pr commands show nodes that have been deleted and added. This kind of diff is the classic symptom of cutting/pasting nodes. The tweaks PR will restore the correct attribution for Terry's original g.get_UNL method. Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/leo-editor/a85acf39-2e61-4714-95c0-4a4ad064638bn%40googlegroups.com.
