W dniu 07.05.2018 o 14:46, Koen Vandeputte pisze: > > > On 2018-05-06 23:41, Koen Vandeputte wrote: >> >> >> On 06-05-18 19:25, Tomasz Maciej Nowak wrote: >>> Hi Koen. >>> >>> W dniu 03.05.2018 o 11:57, Koen Vandeputte pisze: >>>> All, >>>> >>>> Please skip these. >>>> It does not apply anymore due to: "kernel: add missing in6_dev_put_clear >>>> call to an ipv6 network patch" >>>> >>>> Also .. yet another kernel bump was released yesterday .. >>> If You'll be doing kernel bump for 4.14.39 or later, You cane safely drop >>> these patches: >>> >>> target/linux/mvebu/patches-4.14/522-PCI-aardvark-fix-logic-in-PCI-configuration-read-write-functions.patch >>> target/linux/mvebu/patches-4.14/523-PCI-aardvark-set-PIO_ADDR_LS-correctly-in-advk_pcie_rd_conf.patch >>> target/linux/mvebu/patches-4.14/524-PCI-aardvark-set-host-and-device-to-the-same-MAX-payload-size.patch >>> target/linux/mvebu/patches-4.14/525-PCI-aardvark-use-isr1-instead-of-isr0-interrupt-in-legacy-irq-mode.patch >>> target/linux/mvebu/patches-4.14/526-PCI-aardvark-disable-LOS-state-by-default.patch >>> target/linux/mvebu/patches-4.14/527-PCI-aardvark-fix-PCIe-max-read-request-size-setting.patch >>> >>> Thanks for all Your work. >> Hi, >> I started working on the V2 last week, and it seems not all of these were >> upstreamed. >> If I have some time, I'll check it further in detail tomorrow how it should >> be handled. >> > I've gone into the details of it, also checking the online discussions > between the author and Bjorn Helgaas. [1] > > It seems it is still ongoing .. and the safest option according to me is to > keep the MPS at 128 for now, ensuring no malformed communication happens > between the RC and the endpoints. > Dropping this patch would be cleaner and might very slightly improving > performance, but at the cost of potential communication errors with specific > devices. > > The disable-LoS patch is similar and should also be kept for now. > > > Please let me know if you disagree (and why :) ) >
OK, seems I was bit to hasty. That's a valid point about those two patches. Given that Thomas dropped the mentioned patches in later series revision [1] and is working on better solution, let's keep them for now (better safe than sorry). Initially I added the whole series regarding this [2] bug report. That made the mini PCIe port working without kernel lockups or panics. After some of the patches got accepted, I removed the series and included the fixes which still made my cards JWX6051 (ath9k) and U7612E-H1 (mt76) working, didn't observe any issues. Unfortunately since the beginning my board is missing one element and it's not providing 1.5V to mini PCIe port, so cards requiring it do not work. Because of that my testing has been limited. Last week I ordered the missing element and at end of the week I should be ready for testing the rest of cards. I'll report back if those test show any difference with or without those patches. 1. https://www.spinics.net/lists/linux-pci/msg70774.html 2. https://bugzilla.kernel.org/show_bug.cgi?id=196339 > > Koen > > [1] https://patchwork.kernel.org/patch/9976017/ >>>> V2 later on .. >>>> >>>> Koen >>>> >>> Cheers, Tomasz. >>> >> > > > _______________________________________________ > Lede-dev mailing list > Lede-dev@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/lede-dev Regards, Tomasz. -- TMN _______________________________________________ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
