On 04/16/2018 12:54 AM, Hauke Mehrtens wrote: > The missing dependency causes build problems on systems without PCI > support. > The ath10k_pci kernel module depends on PCI support so this dependency > should be added. ath10k now also supported the ahb interface on the > IPQ4019 SoC, but this SoC also has PCI support so this extra dependency > is not as problem.
LGTM.
Even if ath10k-ct gets fixed to allow building the AHB part without PCI
support, the dependency should look like
@PCI_SUPPORT||<list_of_ahb_targets>, so we don't needlessly build the
module for devices that can never be connected to ath10k hardware (as long
as ath10k USB dongles aren't a thing...)
Matthias
>
> Fixes: d0f3dd5b9f34176 ("ath10k-ct: update to latest version, enable AHB.")
> Signed-off-by: Hauke Mehrtens <ha...@hauke-m.de>
> ---
> package/kernel/ath10k-ct/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/kernel/ath10k-ct/Makefile
> b/package/kernel/ath10k-ct/Makefile
> index 1725bb7d17..9c69dee72f 100644
> --- a/package/kernel/ath10k-ct/Makefile
> +++ b/package/kernel/ath10k-ct/Makefile
> @@ -29,7 +29,7 @@ include $(INCLUDE_DIR)/package.mk
> define KernelPackage/ath10k-ct
> SUBMENU:=Wireless Drivers
> TITLE:=ath10k-ct driver optimized for CT ath10k firmware
> - DEPENDS:=+kmod-mac80211 +kmod-ath +@DRIVER_11N_SUPPORT
> +@DRIVER_11AC_SUPPORT +@DRIVER_11W_SUPPORT +kmod-hwmon-core
> + DEPENDS:=+kmod-mac80211 +kmod-ath +@DRIVER_11N_SUPPORT
> +@DRIVER_11AC_SUPPORT +@DRIVER_11W_SUPPORT @PCI_SUPPORT +kmod-hwmon-core
> FILES:=\
> $(PKG_BUILD_DIR)/ath10k$(CT_KVER)/ath10k_pci.ko \
> $(PKG_BUILD_DIR)/ath10k$(CT_KVER)/ath10k_core.ko
>
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
