On Tue, Apr 3, 2018 at 4:33 PM, Karl Palsson <ka...@tweak.net.au> wrote: > > Alexandru Ardelean <ardeleana...@gmail.com> wrote: >> On Sat, Mar 31, 2018 at 9:45 AM, Hans Dedecker >> <dedec...@gmail.com> wrote: >> > On Sat, Mar 31, 2018 at 12:25 AM, Rosen Penev <ros...@gmail.com> wrote: >> >> From: Daniel Engberg <daniel.engberg.li...@pyret.net> >> >> >> >> Update (lib)json-c to 0.13 >> > What are the changes? >> > Is there any size increase ? >> > Please be a bit more verbose in the git commit description >> > >> >> From me, this is a NAK. >> See https://github.com/lede-project/source/pull/1575 >> >> The size increase is reasonably big [percentage-wise +30%, even >> though the lib is small]. 0.13 adds a few new features, but >> nothing that is of interest to OpenWrt. The set of features in >> 0.12 is sufficient for now. > > And fixes a pile of bugs, and improves performance :)
Not sure about performance, but I agree on the bugs part. > > Please remember that this library is heavily used by packages > too, not just the ones in core. Yes, it's bigger, but hey, linux > 4.14 is bigger than linux 4.9 too. I agree on the linux 4.14 vs 4.9 size increase, but I would not use it as an argument. OpenWrt has also run on systems with 2 MB of flash, which is why it's interesting to have disable flags for whatever is possible. Or create libjson-c variants [libjson-c-tiny, libjson-c-full]. That may work for both core & packages. > >> What would be interesting in 0.13 or later, is to have disable >> flags, to keep it slim. And maybe switch to cmake, since it's >> better supported, and preferred [by various users of >> libjson-c]. Maybe once we have the disable flags, then it would >> be fine to upgrade. > > cmake better supported what? Upstream's "how to build" > documentation doesn't even _mention_ cmake. The extended docs say > that cmake is there for win32. tbh, i did not check the docs about cmake; i built libjson-c with cmake on my linux desktop a while back; not on OpenWrt though ; i also had to push some fixes for linux though: https://github.com/json-c/json-c/pull/321/files https://github.com/json-c/json-c/pull/329/files I'd say, cmake is better supported in 0.13 vs 0.12. But it's fine if we don't agree here :) > > Cheers, > Karl P _______________________________________________ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
