On 07/18/2017 05:32 AM, Yousong Zhou wrote: > On 18 July 2017 at 06:10, Hauke Mehrtens <ha...@hauke-m.de> wrote: >> Now we can activate some compiler optimizations for the cortex A7. >> >> Signed-off-by: Hauke Mehrtens <ha...@hauke-m.de> >> --- >> package/boot/uboot-sunxi/Makefile | 17 +++++++++++++ >> target/linux/sunxi/Makefile | 3 +-- >> target/linux/sunxi/cortexa7/target.mk | 12 ++++++++++ >> target/linux/sunxi/cortexa8/target.mk | 12 ++++++++++ >> target/linux/sunxi/image/Makefile | 45 >> +++++++++++++++++++++-------------- >> 5 files changed, 69 insertions(+), 20 deletions(-) >> create mode 100644 target/linux/sunxi/cortexa7/target.mk >> create mode 100644 target/linux/sunxi/cortexa8/target.mk >>
..... >> diff --git a/target/linux/sunxi/Makefile b/target/linux/sunxi/Makefile >> index 483c9eb21c..65d43358c9 100644 >> --- a/target/linux/sunxi/Makefile >> +++ b/target/linux/sunxi/Makefile >> @@ -11,8 +11,7 @@ ARCH:=arm >> BOARD:=sunxi >> BOARDNAME:=Allwinner A1x/A20/A3x >> FEATURES:=fpu usb ext4 display rtc squashfs >> -CPU_TYPE:=cortex-a8 >> -CPU_SUBTYPE:=vfpv3 >> +SUBTARGETS:=cortexa8 cortexa7 > > I prefer we use a dash in the subtarget name, e.g. cortex-a7. It's > just more common. I tried cortex-a7, but that will result in the config option cortex_a7 and having a mixture of _ and - is more confusing I think. >> MAINTAINER:=Zoltan HERPAI <wigy...@uid0.hu> >> >> KERNEL_PATCHVER:=4.9 >> diff --git a/target/linux/sunxi/cortexa7/target.mk >> b/target/linux/sunxi/cortexa7/target.mk >> new file mode 100644 >> index 0000000000..f0dbcbe751 >> --- /dev/null >> +++ b/target/linux/sunxi/cortexa7/target.mk >> @@ -0,0 +1,12 @@ >> +# >> +# Copyright (C) 2013-2016 OpenWrt.org > > New file should use updated copyright header. OK, Will update that. >> +# >> +# This is free software, licensed under the GNU General Public License v2. >> +# See /LICENSE for more information. >> +# >> + >> +include $(TOPDIR)/rules.mk >> + >> +BOARDNAME:=Allwinner A20/A3x >> +CPU_TYPE:=cortex-a7 >> +CPU_SUBTYPE:=neon-vfpv4 >> diff --git a/target/linux/sunxi/cortexa8/target.mk >> b/target/linux/sunxi/cortexa8/target.mk >> new file mode 100644 >> index 0000000000..c0594721da >> --- /dev/null >> +++ b/target/linux/sunxi/cortexa8/target.mk >> @@ -0,0 +1,12 @@ >> +# >> +# Copyright (C) 2013-2016 OpenWrt.org >> +# >> +# This is free software, licensed under the GNU General Public License v2. >> +# See /LICENSE for more information. >> +# >> + >> +include $(TOPDIR)/rules.mk >> + >> +BOARDNAME:=Allwinner A1x >> +CPU_TYPE:=cortex-a8 >> +CPU_SUBTYPE:=vfpv3 >> diff --git a/target/linux/sunxi/image/Makefile >> b/target/linux/sunxi/image/Makefile >> index d0d86ee10d..1e8cedc70c 100644 >> --- a/target/linux/sunxi/image/Makefile >> +++ b/target/linux/sunxi/image/Makefile >> @@ -39,6 +39,8 @@ define Device/Default >> IMAGE/sdcard.img.gz := sunxi-sdcard | append-metadata | gzip >> endef >> >> +ifeq ($(SUBTARGET),cortexa8) >> + > > How about we just move them into subfiles like cortex-a8.mk and cortex-a7.mk? Yes that sounds good, I will do that. Hauke _______________________________________________ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
