On 2017-06-18 21:06, Matthew McClintock wrote:
> On Sat, Jun 17, 2017 at 7:35 AM, Felix Fietkau <n...@nbd.name> wrote:
>> On 2017-06-16 20:58, Matthew McClintock wrote:
>>> This will output when a job starts and stops:
>>>
>>> $ make -j24 V=e
>>> [ snip ]
>>> make[3] -C package/network/config/firewall compile
>>> make -r -C package/network/config/firewall
>>> BUILD_SUBDIR=package/network/config/firewall BUILD_VARIANT= compile finished
>>>
>>> It's quite useful for debugging parallel builds to see what actually
>>> failed without having to re-run -j1 V=s when the issue may not occur at
>>> all.
>>>
>>> Signed-off-by: Matthew McClintock <msm-...@mcclintock.net>
>> I think this is a good idea. Could you please make the following changes
>> to it:
>>
>> - clean up the "make ... finished" part to look like the earlier msg
>> that indicated the start of the build. Preferably both should indicate
>> which build variant is being used (where present).
>>
>> - print the "make ... failed" message by default
>
> How about this? Print a started, and always print the finished message.
>
> make -r -C package/network/config/firewall
> BUILD_SUBDIR=package/network/config/firewall BUILD_VARIANT= compile
> started
> make[3] -C package/network/config/firewall compile
> make -r -C package/network/config/firewall
> BUILD_SUBDIR=package/network/config/firewall BUILD_VARIANT= compile
> finished
>
> SUBMAKE:=cmd() { printf "$(_Y) make $$* started$(_N)\n" >&8; $(MAKE)
> $$* || { printf "$(_Y) make $$* failed$(_N)\n" >&8; false; }; printf
> "$(_Y) make $$* finished$(_N)\n" >&8; }; cmd
Looks a bit ugly. I'd prefer a filtered version that shows the essential
parts in a more concise way.
- Felix
_______________________________________________
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev
