On 2017-06-15 14:17, Rafał Miłecki wrote: > From: Rafał Miłecki <ra...@milecki.pl> > > Counting commits to determine revision number is a wrong idea when there > are branches in a project. This could generate the same revision for > different git commits, e.g.: > > For master branch: > ./scripts/getver.sh bb9d2aa868 > r3438-bb9d2aa868 > > For lede-17.01 branch: > ./scripts/getver.sh 2e206c79cc > r3438-2e206c79cc > > Let's use git's sha1 instead and add amount of local commits on top of > this, e.g.: > ./scripts/getver.sh > c00fbaf670+3 > > Signed-off-by: Rafał Miłecki <ra...@milecki.pl> NACK. If you care about correctness, I think we should have some branch info in there instead. The numbers are still useful to get a rough estimate of how old a particular build is.
- Felix _______________________________________________ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
