Hi, On 09/05/17 08:47, Felix Fietkau wrote: > On 2017-05-09 08:46, Mathias Kresin wrote: >> 09.05.2017 00:44, Valentin Spreckels: >>> Signed-off-by: Valentin Spreckels >>> <valentin.spreck...@informatik.uni-oldenburg.de> >>> --- >> >> Thanks a lot for your patch. Would you please add a commit message which >> describes the issue you are trying to fix. At the moment I fail to see >> why this change is required. >> >> I rather suspect that the whole pppoa interface handling can be removed >> from dsl_notify.sh. Isn't it handled by netifd now days? > pppoa needs special treatment, because it connects to ATM directly > without going through a netdev.
May I suggest to add this information as comment in the script? > For pppoe, this makes no sense, so this patch should be unnecessary. I withdraw the patch. Valentin _______________________________________________ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
