On 28 April 2017 at 20:12, Felix Fietkau <n...@nbd.name> wrote:
> On 2017-04-28 14:56, Roman Yeryomin wrote:
>> Signed-off-by: Roman Yeryomin <ro...@advem.lv>
>> ---
>> package/base-files/files/lib/functions/board.sh | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>> create mode 100644 package/base-files/files/lib/functions/board.sh
>>
>> diff --git a/package/base-files/files/lib/functions/board.sh
>> b/package/base-files/files/lib/functions/board.sh
>> new file mode 100644
>> index 0000000..28f3bad
>> --- /dev/null
>> +++ b/package/base-files/files/lib/functions/board.sh
>> @@ -0,0 +1,17 @@
>> +#!/bin/sh
>> +
>> +sysinfo()
>> +{
>> + local file=$1
>> + [ -e /tmp/sysinfo/$file ] && cat /tmp/sysinfo/$file || echo "generic"
>> +}
>> +
>> +board_name()
>> +{
>> + sysinfo board_name
>> +}
>> +
>> +board_model()
>> +{
>> + sysinfo model
>> +}
> Do we really need board_model() at all? I think it's better to leave the
> board_name() function where it is instead of adding this extra include file.
>
If we don't need it why it exists then?
I think it's better to leave as separate file because it's mostly used
separately, sourcing platform file, but for functions.sh it's
negligible change.
Regards,
Roman
_______________________________________________
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev
