I think this patch needn't be reverted as it do fix the incorrect setting of marking port4 as eth1.What we need is just another commit to separate ar9331/ar934x devices from these to correct the port order of the 4 lan ports. Regards. Chuanhong Guo
2017-02-21 2:39 GMT+08:00 John Crispin <j...@phrozen.org>: > > > On 20/02/2017 19:31, Piotr Dymacz wrote: >> Hello, >> >> 2017-02-20 13:11 GMT+01:00 Conor O'Gorman <i...@conorogorman.net>: >>> On 18/02/17 14:32, Weijie Gao wrote: >>>> >>>> For AR71XX devices, GMAC1 always connects port 0 of the built-in switch, >>>> as the CPU port. >>>> >>>> This patch sets correct vlan for some devices with wrong settings: >>>> a) mark port 0 as CPU port, tagged >>>> b) reverse port order, marking these ports untagged >>>> >>> This change affects all these boards: >>> dir-615-i1|\ >>> omy-g1|\ >>> r6100|\ >>> smart-300|\ >>> tl-mr3420-v2|\ >>> tl-wdr6500-v2|\ >>> tl-wr841n-v8|\ >>> tl-wr940n-v4|\ >>> tl-wr941nd-v5|\ >>> tl-wr941nd-v6|\ >>> wnr1000-v2|\ >>> wnr2000-v4|\ >>> wnr2200|\ >>> wnr612-v2|\ >>> wpn824n) >>> >>> Which ones have you tested? >> >> At least for TL-WR841N v8 and TL-MR3420 v2 switch port mapping should be: >> "0@eth1" "1:lan:4" "2:lan:1" "3:lan:2" "4:lan:3" >> >> --- >> Cheers, >> Piotr >> >> _______________________________________________ >> Lede-dev mailing list >> Lede-dev@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/lede-dev >> > > looks like i merged this too early, i had a look at the file beforehand > and concluded that only one board was changed, apparently it was too > early. i'll revert the commit > > John > > _______________________________________________ > Lede-dev mailing list > Lede-dev@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/lede-dev _______________________________________________ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
