Hi Kristian,
Thanks a lot for considering all our comments, it looks (almost) OK for me now.
There are just some minor, only cosmetic things (below, inline) which
I think still need to be fixed (yes, I'm kind of pedantic type).
Cheers,
Piotr
2017-02-04 13:56 GMT+01:00 Kristian Evensen <kristian.even...@gmail.com>:
[...]
> diff --git a/target/linux/ramips/dts/D240.dts
> b/target/linux/ramips/dts/D240.dts
> new file mode 100644
> index 0000000..051204a
> --- /dev/null
> +++ b/target/linux/ramips/dts/D240.dts
> @@ -0,0 +1,153 @@
> +/*
> + * BSD LICENSE
> + *
> + * Copyright(c) 2017 Kristian Evensen <kristian.even...@gmail.com>.
> + * All rights reserved.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions
> + * are met:
> + *
> + * * Redistributions of source code must retain the above copyright
> + * notice, this list of conditions and the following disclaimer.
> + * * Redistributions in binary form must reproduce the above copyright
> + * notice, this list of conditions and the following disclaimer in
> + * the documentation and/or other materials provided with the
> + * distribution.
> + * * Neither the name of Broadcom Corporation nor the names of its
> + * contributors may be used to endorse or promote products derived
> + * from this software without specific prior written permission.
> + *
> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
> + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
> + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
> + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
> + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
> + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
> + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> + */
> +
> +/dts-v1/;
> +
> +#include "mt7620a.dtsi"
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/input/input.h>
> +
> +/ {
> + compatible = "d240", "ralink,mt7620a-soc";
> + model = "D240";
You should put here full model name, including manufacturer name:
"Sanlinking Technologies D240".
> +
> + chosen {
> + bootargs = "console=ttyS0,115200";
> + };
> +
> + gpio-leds {
> + compatible = "gpio-leds";
New line here, please.
> + power {
> + label = "d240:blue:power";
> + gpios = <&gpio1 14 GPIO_ACTIVE_HIGH>;
> + };
New line here, please.
> + usb {
> + label = "d240:blue:usb";
> + gpios = <&gpio1 15 GPIO_ACTIVE_HIGH>;
> + };
New line here, please.
> + air {
> + label = "d240:blue:wifi";
> + gpios = <&gpio3 0 GPIO_ACTIVE_LOW>;
> + };
> + };
> +
> + gpio-keys-polled {
> + compatible = "gpio-keys-polled";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + poll-interval = <20>;
New line here, please.
> + reset {
> + label = "reset";
> + gpios = <&gpio0 1 GPIO_ACTIVE_LOW>;
> + linux,code = <KEY_RESTART>;
> + };
> + };
> +};
> +
> +&gpio1 {
> + status = "okay";
> +};
> +
> +&gpio3 {
> + status = "okay";
> +};
> +
> +&spi0 {
> + status = "okay";
> +
> + en25q128@0 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "jedec,spi-nor";
> + reg = <0>;
> + spi-max-frequency = <10000000>;
> +
> + partition@0 {
> + label = "u-boot";
> + reg = <0x0 0x30000>;
> + read-only;
> + };
> +
> + partition@30000 {
> + label = "u-boot-env";
> + reg = <0x30000 0x10000>;
> + read-only;
> + };
> +
> + factory: partition@40000 {
> + label = "factory";
> + reg = <0x40000 0x10000>;
> + read-only;
> + };
> +
> + partition@50000 {
> + label = "firmware";
> + reg = <0x50000 0xfb0000>;
> + };
> + };
> +};
> +
> +&sdhci {
> + status = "okay";
> +};
> +
> +&ehci {
> + status = "okay";
> +};
> +
> +&ohci {
> + status = "okay";
> +};
> +
> +ðernet {
> + mtd-mac-address = <&factory 0x4>;
> + ralink,port-map = "wllll";
> +};
> +
> +&wmac {
> + ralink,mtd-eeprom = <&factory 0>;
> +};
> +
> +&pinctrl {
> + state_default: pinctrl0 {
> + default {
> + ralink,group = "i2c", "uartf", "wled", "spi refclk",
> "pa";
> + ralink,function = "gpio";
> + };
> + };
> +};
> +
> +&pcie {
> + status = "okay";
> +};
[...]
_______________________________________________
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev
