Hi! On Mon, Jan 16, 2017 at 11:08:57AM +0100, Stanislaw Gruszka wrote: > On Mon, Jan 16, 2017 at 04:06:25AM +0100, Daniel Golle wrote: > > From: Claudio Mignanti <c.migna...@gmail.com> > > > > This is needed for devices without support for PCI MWI. See also > > https://dev.openwrt.org/changeset/21850 > > > > Signed-off-by: Daniel Golle <dan...@makrotopia.org> > > --- > > drivers/net/wireless/ralink/rt2x00/rt2x00pci.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00pci.c > > b/drivers/net/wireless/ralink/rt2x00/rt2x00pci.c > > index eb6dbcd4fddf..4becfeb75ba8 100644 > > --- a/drivers/net/wireless/ralink/rt2x00/rt2x00pci.c > > +++ b/drivers/net/wireless/ralink/rt2x00/rt2x00pci.c > > @@ -94,8 +94,10 @@ int rt2x00pci_probe(struct pci_dev *pci_dev, const > > struct rt2x00_ops *ops) > > > > pci_set_master(pci_dev); > > > > +#ifdef CONFIG_PCI_SET_MWI > > if (pci_set_mwi(pci_dev)) > > rt2x00_probe_err("MWI not available\n"); > > +#endif > > There is no CONFIG_PCI_SET_MWI in the kernel. This patch is either not > needed (pci subsystem has own PCI_DISABLE_MWI define) or wrong (we > should not call this function for some devices).
Is anyone with good long-term memory able to tell why this was needed in first place? Can we assume it to be obsolete when using modern kernels? Cheers Daniel _______________________________________________ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
