Hi Jo-Philipp, sorry, I did not notice this in the last review, but how is it possible to let CONFIG_TARGET_EXT4_RESERVED_PCT be empty?
config/Config-images.in: config TARGET_EXT4_RESERVED_PCT int "Percentage of reserved blocks in root filesystem" depends on TARGET_ROOTFS_EXT4FS default 0 So unless removing the CONFIG_TARGET_EXT4_RESERVED_PCT line manually from .config you'll get the default value from make menuconfig, and thus -m 0 is passed to make_ext4fs... Regards, mhei Am Dienstag, 25. Oktober 2016, 13:02:03 CEST schrieb Jo-Philipp Wich: > Allow CONFIG_TARGET_EXT4_RESERVED_PCT to be empty as make_ext4fs is usually > able to figure out a suitable default. > > Signed-off-by: Jo-Philipp Wich <j...@mein.io> > --- > include/image.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/image.mk b/include/image.mk > index 8b7d91d..59dd66f 100644 > --- a/include/image.mk > +++ b/include/image.mk > @@ -245,7 +245,7 @@ define Image/mkfs/ext4 > $(STAGING_DIR_HOST)/bin/make_ext4fs \ > -l $(E2SIZE) -b $(CONFIG_TARGET_EXT4_BLOCKSIZE) \ > -i $(CONFIG_TARGET_EXT4_MAXINODE) \ > - -m $(CONFIG_TARGET_EXT4_RESERVED_PCT) \ > + $(if $(CONFIG_TARGET_EXT4_RESERVED_PCT),-m > $(CONFIG_TARGET_EXT4_RESERVED_PCT)) \ $(if > $(CONFIG_TARGET_EXT4_JOURNAL),,-J) \ > $(if $(SOURCE_DATE_EPOCH),-T $(SOURCE_DATE_EPOCH)) \ > $@ $(call mkfs_target_dir,$(1))/ _______________________________________________ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
