Hi, you're correct, this patch does not change any behaviour at the moment. I'm currently doing work on a device which requires a non-default USB triggering device. One option is to just use ucidef_set_led_usbdev for this single device. Then there's the option to bring this functionality (additional parameters) to the local set_usb_led() functions. The idea of this patch was to clean up the function calls in 01_leds and unify the configuration calls for LEDs.
What about this approach: without changing every call to set_usb_led(), we leave set_usb_led() in place, don't use a hardcoded triggering device there, but instead have a second parameter, with a default value. Something like ${2:-wlan0} ? This would leave all other function calls untouched and at the same time introduce more flexibility there. Best regards, P.Wassi _______________________________________________ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev