On 07/06/2016 12:11, Dan Bugnar wrote:
> From: Dan Bugnar <dnbug...@ocedo.com>
>
> The next message needs to be written after the data of current message.
> This was adding "sizeof(struct log_head)" bytes between messages.
>
> Signed-off-by: Dan Bugnar <danut...@gmail.com>
coming back to these patches, i fail to see why you remove the padding.
this will guarantee that struct log_head pointers are always 4 byte
aligned, thus preventing unaligned accesses from happening. imho the
code should nt be changed, it is there for a reason.
John
> ---
> log/syslog.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/log/syslog.c b/log/syslog.c
> index e8b6774..2042e93 100644
> --- a/log/syslog.c
> +++ b/log/syslog.c
> @@ -51,7 +51,7 @@ static regex_t pat_tstamp;
> static struct log_head*
> log_next(struct log_head *h, int size)
> {
> - struct log_head *n = (struct log_head *) &h->data[PAD(sizeof(struct
> log_head) + size)];
> + struct log_head *n = (struct log_head *) &h->data[size];
>
> return (n >= log_end) ? (log) : (n);
> }
>
_______________________________________________
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev
