Vincent Snijders wrote:
> Felipe Monteiro de Carvalho schreef:
>> Hello,
>>
>> Here is my first patch. I checked that Window Titles work correct with
>> UTF-8 if you recompile win32 with WindowsUnicodeSupport
>>
>> I also checked that titles work correctly with Ansi if you don´t set
>> that define
>>
>> Marc, please review this.
>>
>> I created a global variable on win32proc called UnicodeEnabledOS that
>> says if we are running on a NT version or a 9x version.
Doesn't FPC already have such variable ?
> I am not sure we should have all those {$ifdef WindowsUnicodeSupport} in
> the code. Why not have just the ifdef WindowsUnicodeSupport part and
> remove the else part?
For the time being, until all is implemented, I think it is good to have it.
In some cases I think you only have to ifdef the
"if UnicodeEnabledOS then ... else " part.
> Is it really valuable to have the else part, maybe a separate branch
For the time being, I see a need (we can release .20 without having all
converted). To have a separate branch... to much work.
For a start I thinkk the patch looks OK
Marc
_________________________________________________________________
To unsubscribe: mail [EMAIL PROTECTED] with
"unsubscribe" as the Subject
archives at http://www.lazarus.freepascal.org/mailarchives
