2010/12/25 Maxim Ganetsky <[email protected]>:
> 24.12.2010 20:44, cobines пишет:
>>
>> 2010/12/24 Vincent Snijders<[email protected]>:
>>>
>>> 2010/12/24 cobines<[email protected]>:
>>>>
>>>> Hi,
>>>>
>>>> Please consider reverting commit 25431 from 0.9.30. It fixes issue:
>>>>
>>>> http://bugs.freepascal.org/view.php?id=0015180
>>>>
>>>> but has some regressions.
>>>>
>>>> See new issue opened for explanation:
>>>>
>>>> http://bugs.freepascal.org/view.php?id=16742
>>>>
>>>
>>> What is worse?
>>
>> I think maintaining what was in 0.9.28 is better.
>
> It works in more cases than before and doesn't have regressions AFAICS
> (before it didn't work in the case from your second bug too). So I don't see
> the need for reverting?

It fixes collections, breaks subcomponents.

Before:

TFORM1.STRINGGRID1.COLUMNS.TITLE.CAPTION
TFORM1.LABELEDEDIT1.EDITLABEL.CAPTION
TFORM1.BUTTONPANEL1.OKBUTTON.CAPTION

After:

TFORM1.STRINGGRID1.COLUMNS[0].TGRIDCOLUMNTITLE.CAPTION
TFORM1.SUBLABEL.CAPTION
TFORM1.OKBUTTON.CAPTION


It sort of switches one bug for another. But if you prefer that it is
better now then it's OK. I was just asking for considering it.

--
cobines

--
_______________________________________________
Lazarus mailing list
[email protected]
http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus

Reply via email to